From: Wang Qing <wangqing@vivo.com>
Date: Mon, 13 Dec 2021 09:44:20 +0000 (-0800)
Subject: mailbox: zynq: add missing of_node_put before return
X-Git-Tag: baikal/aarch64/sdk6.1~4884^2~8
X-Git-Url: https://git.baikalelectronics.ru/sdk/?a=commitdiff_plain;h=fc20c032b64c71288429cf345e6255f4fb515efb;p=kernel.git

mailbox: zynq: add missing of_node_put before return

Fix following coccicheck warning:
WARNING: Function "for_each_available_child_of_node"
should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wang Qing <wangqing@vivo.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---

diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
index f44079d62b1a7..31a0fa9142744 100644
--- a/drivers/mailbox/zynqmp-ipi-mailbox.c
+++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
@@ -655,6 +655,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
 		mbox->pdata = pdata;
 		ret = zynqmp_ipi_mbox_probe(mbox, nc);
 		if (ret) {
+			of_node_put(nc);
 			dev_err(dev, "failed to probe subdev.\n");
 			ret = -EINVAL;
 			goto free_mbox_dev;