From: Masahiro Yamada <masahiroy@kernel.org>
Date: Thu, 20 Jan 2022 19:22:05 +0000 (+0900)
Subject: certs: Fix build error when CONFIG_MODULE_SIG_KEY is empty
X-Git-Tag: baikal/mips/sdk6.1~6563^2
X-Git-Url: https://git.baikalelectronics.ru/sdk/?a=commitdiff_plain;h=db7abe134734fdc4d19f94a1df7613e441c9ce04;p=kernel.git

certs: Fix build error when CONFIG_MODULE_SIG_KEY is empty

Since 179d611375f8 ("certs: simplify $(srctree)/ handling and remove
config_filename macro"), when CONFIG_MODULE_SIG_KEY is empty,
signing_key.x509 fails to build:

    CERT    certs/signing_key.x509
  Usage: extract-cert <source> <dest>
  make[1]: *** [certs/Makefile:78: certs/signing_key.x509] Error 2
  make: *** [Makefile:1831: certs] Error 2

Pass "" to the first argument of extract-cert to fix the build error.

Link: https://lore.kernel.org/linux-kbuild/20220120094606.2skuyb26yjlnu66q@lion.mk-sys.cz/T/#u
Fixes: 179d611375f8 ("certs: simplify $(srctree)/ handling and remove config_filename macro")
Reported-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Michal Kubecek <mkubecek@suse.cz>
---

diff --git a/certs/Makefile b/certs/Makefile
index 0c459cfd09dfd..3ea7fe60823f5 100644
--- a/certs/Makefile
+++ b/certs/Makefile
@@ -75,7 +75,7 @@ endif
 $(obj)/system_certificates.o: $(obj)/signing_key.x509
 
 $(obj)/signing_key.x509: $(X509_DEP) $(obj)/extract-cert FORCE
-	$(call if_changed,extract_certs,$(if $(X509_DEP),$<,$(CONFIG_MODULE_SIG_KEY)))
+	$(call if_changed,extract_certs,$(if $(CONFIG_MODULE_SIG_KEY),$(if $(X509_DEP),$<,$(CONFIG_MODULE_SIG_KEY)),""))
 endif # CONFIG_MODULE_SIG
 
 targets += signing_key.x509