From: Colin Ian King Date: Wed, 12 Aug 2020 01:35:53 +0000 (-0700) Subject: fs/ufs: avoid potential u32 multiplication overflow X-Git-Tag: baikal/mips/sdk5.9~12923^2~58 X-Git-Url: https://git.baikalelectronics.ru/sdk/?a=commitdiff_plain;h=c62758791dbd54f5956587eebbe2ee0184951c7f;p=kernel.git fs/ufs: avoid potential u32 multiplication overflow The 64 bit ino is being compared to the product of two u32 values, however, the multiplication is being performed using a 32 bit multiply so there is a potential of an overflow. To be fully safe, cast uspi->s_ncg to a u64 to ensure a 64 bit multiplication occurs to avoid any chance of overflow. Fixes: 66695f221af2 ("ufs: NFS support") Signed-off-by: Colin Ian King Signed-off-by: Andrew Morton Cc: Evgeniy Dushistov Cc: Alexey Dobriyan Link: http://lkml.kernel.org/r/20200715170355.1081713-1-colin.king@canonical.com Addresses-Coverity: ("Unintentional integer overflow") Signed-off-by: Linus Torvalds --- diff --git a/fs/ufs/super.c b/fs/ufs/super.c index 1da0be667409b..e3b69fb280e8c 100644 --- a/fs/ufs/super.c +++ b/fs/ufs/super.c @@ -101,7 +101,7 @@ static struct inode *ufs_nfs_get_inode(struct super_block *sb, u64 ino, u32 gene struct ufs_sb_private_info *uspi = UFS_SB(sb)->s_uspi; struct inode *inode; - if (ino < UFS_ROOTINO || ino > uspi->s_ncg * uspi->s_ipg) + if (ino < UFS_ROOTINO || ino > (u64)uspi->s_ncg * uspi->s_ipg) return ERR_PTR(-ESTALE); inode = ufs_iget(sb, ino);