From: Carlo Caione <carlo@endlessm.com> Date: Tue, 30 May 2017 20:39:46 +0000 (+0200) Subject: HID: asus: Stop underlying hardware on remove X-Git-Tag: baikal/aarch64/sdk6.1~16689^2 X-Git-Url: https://git.baikalelectronics.ru/sdk/?a=commitdiff_plain;h=96472256e1982758f613a2a4d4158e1a045e7b21;p=kernel.git HID: asus: Stop underlying hardware on remove We are missing a call to hid_hw_stop() on the remove hook. Among other things this is causing an Oops when (re-)starting GNOME / upowerd / ... after the module has been already rmmod-ed. Signed-off-by: Carlo Caione <carlo@endlessm.com> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> --- diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 101ab2e63d188..a6268f2f7408a 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -537,6 +537,8 @@ static void asus_remove(struct hid_device *hdev) drvdata->kbd_backlight->removed = true; cancel_work_sync(&drvdata->kbd_backlight->work); } + + hid_hw_stop(hdev); } static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,