From: Junlin Yang Date: Fri, 9 Apr 2021 13:54:26 +0000 (+0800) Subject: pata_ipx4xx_cf: Fix unsigned comparison with less than zero X-Git-Tag: baikal/aarch64/sdk5.9~714 X-Git-Url: https://git.baikalelectronics.ru/sdk/?a=commitdiff_plain;h=94e3dfa2ccd86e06ea401ec4f911a42fa614fdbb;p=kernel.git pata_ipx4xx_cf: Fix unsigned comparison with less than zero [ Upstream commit 92f00355c81b58349e0761408a4000ecb028b64e ] The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'irq', so making 'irq' an int, and change the position to keep the code format. ./drivers/ata/pata_ixp4xx_cf.c:168:5-8: WARNING: Unsigned expression compared with zero: irq > 0 Signed-off-by: Junlin Yang Link: https://lore.kernel.org/r/20210409135426.1773-1-angkery@163.com Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c index abc0e87ca1a8b..43215a4c1e540 100644 --- a/drivers/ata/pata_ixp4xx_cf.c +++ b/drivers/ata/pata_ixp4xx_cf.c @@ -135,12 +135,12 @@ static void ixp4xx_setup_port(struct ata_port *ap, static int ixp4xx_pata_probe(struct platform_device *pdev) { - unsigned int irq; struct resource *cs0, *cs1; struct ata_host *host; struct ata_port *ap; struct ixp4xx_pata_data *data = dev_get_platdata(&pdev->dev); int ret; + int irq; cs0 = platform_get_resource(pdev, IORESOURCE_MEM, 0); cs1 = platform_get_resource(pdev, IORESOURCE_MEM, 1);