From: Christophe JAILLET Date: Sat, 16 May 2020 21:42:05 +0000 (+0200) Subject: dmaengine: tegra210-adma: Fix an error handling path in 'tegra_adma_probe()' X-Git-Tag: baikal/mips/sdk5.9~13657^2 X-Git-Url: https://git.baikalelectronics.ru/sdk/?a=commitdiff_plain;h=6cc644693e7ce62578fc7c316c04531d05f6d0af;p=kernel.git dmaengine: tegra210-adma: Fix an error handling path in 'tegra_adma_probe()' Commit 788a95c3bccc ("dmaengine: tegra210-adma: Fix crash during probe") has moved some code in the probe function and reordered the error handling path accordingly. However, a goto has been missed. Fix it and goto the right label if 'dma_async_device_register()' fails, so that all resources are released. Fixes: 788a95c3bccc ("dmaengine: tegra210-adma: Fix crash during probe") Signed-off-by: Christophe JAILLET Reviewed-by: Jon Hunter Acked-by: Thierry Reding Link: https://lore.kernel.org/r/20200516214205.276266-1-christophe.jaillet@wanadoo.fr Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c index c4ce5dfb149b1..db58d7e4f9fec 100644 --- a/drivers/dma/tegra210-adma.c +++ b/drivers/dma/tegra210-adma.c @@ -900,7 +900,7 @@ static int tegra_adma_probe(struct platform_device *pdev) ret = dma_async_device_register(&tdma->dma_dev); if (ret < 0) { dev_err(&pdev->dev, "ADMA registration failed: %d\n", ret); - goto irq_dispose; + goto rpm_put; } ret = of_dma_controller_register(pdev->dev.of_node,