From: Laurent Pinchart Date: Fri, 4 Dec 2020 11:07:41 +0000 (+0200) Subject: drm: rcar-du: Release vsp device reference in all error paths X-Git-Url: https://git.baikalelectronics.ru/sdk/?a=commitdiff_plain;h=594f967b53ffafd50c5f091f434c4a07e2d0f613;p=kernel.git drm: rcar-du: Release vsp device reference in all error paths Use drmm_add_action_or_reset() instead of drmm_add_action() to ensure the vsp device reference is released in case the function call fails. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index f6a69aa116e6c..4dcb1bfbe2018 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c @@ -364,7 +364,7 @@ int rcar_du_vsp_init(struct rcar_du_vsp *vsp, struct device_node *np, vsp->vsp = &pdev->dev; - ret = drmm_add_action(rcdu->ddev, rcar_du_vsp_cleanup, vsp); + ret = drmm_add_action_or_reset(rcdu->ddev, rcar_du_vsp_cleanup, vsp); if (ret < 0) return ret;