From: Miaoqian Lin Date: Wed, 1 Jun 2022 04:32:22 +0000 (+0400) Subject: mfd: max77620: Fix refcount leak in max77620_initialise_fps X-Git-Tag: baikal/mips/sdk5.9~165 X-Git-Url: https://git.baikalelectronics.ru/sdk/?a=commitdiff_plain;h=4b7e57a53f1ddb78c953a46428b582742856b1b2;p=kernel.git mfd: max77620: Fix refcount leak in max77620_initialise_fps [ Upstream commit b7952837991f4aac6a260fc9516afad8333c5f13 ] of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 1bf61f587955 ("mfd: max77620: Add core driver for MAX77620/MAX20024") Signed-off-by: Miaoqian Lin Reviewed-by: Krzysztof Kozlowski Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20220601043222.64441-1-linmq006@gmail.com Signed-off-by: Sasha Levin --- diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c index fec2096474ad1..a6661e07035ba 100644 --- a/drivers/mfd/max77620.c +++ b/drivers/mfd/max77620.c @@ -419,9 +419,11 @@ static int max77620_initialise_fps(struct max77620_chip *chip) ret = max77620_config_fps(chip, fps_child); if (ret < 0) { of_node_put(fps_child); + of_node_put(fps_np); return ret; } } + of_node_put(fps_np); config = chip->enable_global_lpm ? MAX77620_ONOFFCNFG2_SLP_LPM_MSK : 0; ret = regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG2,