From: Eric W. Biederman Date: Thu, 2 Feb 2023 04:42:43 +0000 (-0800) Subject: objtool: Add a missing comma to avoid string concatenation X-Git-Tag: baikal/aarch64/sdk5.9~18 X-Git-Url: https://git.baikalelectronics.ru/sdk/?a=commitdiff_plain;h=4138b47790dc2e22b71c3513711e5f985faec2dc;p=kernel.git objtool: Add a missing comma to avoid string concatenation commit d57e3dabcc1701cae2cf540311e653eeeb739c8c upstream. Recently the kbuild robot reported two new errors: >> lib/kunit/kunit-example-test.o: warning: objtool: .text.unlikely: unexpected end of section >> arch/x86/kernel/dumpstack.o: warning: objtool: oops_end() falls through to next function show_opcodes() I don't know why they did not occur in my test setup but after digging it I realized I had accidentally dropped a comma in tools/objtool/check.c when I renamed rewind_stack_do_exit to rewind_stack_and_make_dead. Add that comma back to fix objtool errors. Link: https://lkml.kernel.org/r/202112140949.Uq5sFKR1-lkp@intel.com Fixes: 238bcd2dab75 ("exit: Add and use make_task_dead.") Reported-by: kernel test robot Signed-off-by: "Eric W. Biederman" Signed-off-by: Eric Biggers Signed-off-by: Sasha Levin --- diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 14be7d261ae7a..dfd67243faac0 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -144,7 +144,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, "fortify_panic", "usercopy_abort", "machine_real_restart", - "rewind_stack_and_make_dead" + "rewind_stack_and_make_dead", "cpu_bringup_and_idle", };