From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 27 Aug 2021 10:00:23 +0000 (+0300)
Subject: pd: fix a NULL vs IS_ERR() check
X-Git-Url: https://git.baikalelectronics.ru/sdk/?a=commitdiff_plain;h=3375dca0b542c747d29655cf52f7b2741ecebe0e;p=kernel.git

pd: fix a NULL vs IS_ERR() check

blk_mq_alloc_disk() returns error pointers, it doesn't return NULL
so correct the check.

Fixes: 262d431f9000 ("pd: use blk_mq_alloc_disk and blk_cleanup_disk")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20210827100023.GB9449@kili
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c
index 9b3298926356d..675327df6aff9 100644
--- a/drivers/block/paride/pd.c
+++ b/drivers/block/paride/pd.c
@@ -892,7 +892,7 @@ static void pd_probe_drive(struct pd_unit *disk)
 		return;
 
 	p = blk_mq_alloc_disk(&disk->tag_set, disk);
-	if (!p) {
+	if (IS_ERR(p)) {
 		blk_mq_free_tag_set(&disk->tag_set);
 		return;
 	}