From: Randy Dunlap Date: Sun, 26 Feb 2023 05:39:53 +0000 (-0800) Subject: serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it X-Git-Tag: baikal/mips/sdk6.1~82 X-Git-Url: https://git.baikalelectronics.ru/sdk/?a=commitdiff_plain;h=04f7b454949e5f5f8004b464a46a1ebc8c6a71e5;p=kernel.git serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it commit c92ed10e25ce570a2d913321a356d9fdf7b90315 upstream. REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on REGMAP" to "select REGMAP". Fixes: 081bc65f53cd ("drivers/tty/serial/8250: Make Aspeed VUART SIRQ polarity configurable") Cc: stable Signed-off-by: Randy Dunlap Cc: Greg Kroah-Hartman Cc: Oskar Senft Cc: linux-serial@vger.kernel.org Link: https://lore.kernel.org/r/20230226053953.4681-9-rdunlap@infradead.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index b0f62345bc846..583a340f99345 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -253,8 +253,9 @@ config SERIAL_8250_ASPEED_VUART tristate "Aspeed Virtual UART" depends on SERIAL_8250 depends on OF - depends on REGMAP && MFD_SYSCON + depends on MFD_SYSCON depends on ARCH_ASPEED || COMPILE_TEST + select REGMAP help If you want to use the virtual UART (VUART) device on Aspeed BMC platforms, enable this option. This enables the 16550A-