]> git.baikalelectronics.ru Git - kernel.git/commitdiff
platform/x86: int3472: Add terminator to gpiod_lookup_table
authorDaniel Scally <djrscally@gmail.com>
Wed, 16 Feb 2022 22:53:02 +0000 (22:53 +0000)
committerHans de Goede <hdegoede@redhat.com>
Mon, 21 Feb 2022 13:47:59 +0000 (14:47 +0100)
Without the terminator, if a con_id is passed to gpio_find() that
does not exist in the lookup table the function will not stop looping
correctly, and eventually cause an oops.

Fixes: e03864642805 ("platform/x86: int3472: Pass tps68470_regulator_platform_data to the tps68470-regulator MFD-cell")
Signed-off-by: Daniel Scally <djrscally@gmail.com>
Link: https://lore.kernel.org/r/20220216225304.53911-5-djrscally@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/intel/int3472/tps68470_board_data.c

index f93d437fd19281145c9aebb59e7a5a28b82951a9..525f09a3b5ff7427c76f6bf200c11cb2e35f38a6 100644 (file)
@@ -100,7 +100,8 @@ static struct gpiod_lookup_table surface_go_tps68470_gpios = {
        .dev_id = "i2c-INT347A:00",
        .table = {
                GPIO_LOOKUP("tps68470-gpio", 9, "reset", GPIO_ACTIVE_LOW),
-               GPIO_LOOKUP("tps68470-gpio", 7, "powerdown", GPIO_ACTIVE_LOW)
+               GPIO_LOOKUP("tps68470-gpio", 7, "powerdown", GPIO_ACTIVE_LOW),
+               { }
        }
 };