]> git.baikalelectronics.ru Git - kernel.git/commitdiff
iio: dac: ltc2632: Use put_unaligned_be24()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 21 Apr 2020 00:31:23 +0000 (03:31 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 3 May 2020 08:47:19 +0000 (09:47 +0100)
This makes the driver code slightly easier to read.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ltc2632.c

index 7adc91056aa1c0b0fb5a98fbe7283ba5a6c7bb09..ac785595c30fa22007b1dc8e9f5ebc8016c2dbf1 100644 (file)
@@ -12,6 +12,8 @@
 #include <linux/iio/iio.h>
 #include <linux/regulator/consumer.h>
 
+#include <asm/unaligned.h>
+
 #define LTC2632_CMD_WRITE_INPUT_N               0x0
 #define LTC2632_CMD_UPDATE_DAC_N                0x1
 #define LTC2632_CMD_WRITE_INPUT_N_UPDATE_ALL    0x2
@@ -75,9 +77,7 @@ static int ltc2632_spi_write(struct spi_device *spi,
         * 10-, 8-bit input code followed by 4, 6, or 8 don't care bits.
         */
        data = (cmd << 20) | (addr << 16) | (val << shift);
-       msg[0] = data >> 16;
-       msg[1] = data >> 8;
-       msg[2] = data;
+       put_unaligned_be24(data, &msg[0]);
 
        return spi_write(spi, msg, sizeof(msg));
 }