]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/ttm: fix false positive assert
authorChristian König <ckoenig.leichtzumerken@gmail.com>
Fri, 6 Mar 2020 12:41:55 +0000 (13:41 +0100)
committerChristian König <christian.koenig@amd.com>
Wed, 11 Mar 2020 09:52:16 +0000 (10:52 +0100)
The assert sometimes incorrectly triggers when pinned BOs are destroyed.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
Tested-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Link: https://patchwork.freedesktop.org/patch/356737/
drivers/gpu/drm/ttm/ttm_bo.c

index 6d1e91be9c7884d6d302621bfc8b226c94fee89e..9e07c3f75156ba1d7a48bccea82528eca1c7359b 100644 (file)
@@ -151,8 +151,6 @@ static void ttm_bo_add_mem_to_lru(struct ttm_buffer_object *bo,
        struct ttm_bo_device *bdev = bo->bdev;
        struct ttm_mem_type_manager *man;
 
-       dma_resv_assert_held(bo->base.resv);
-
        if (!list_empty(&bo->lru))
                return;
 
@@ -604,7 +602,8 @@ static void ttm_bo_release(struct kref *kref)
                 */
                if (bo->mem.placement & TTM_PL_FLAG_NO_EVICT) {
                        bo->mem.placement &= ~TTM_PL_FLAG_NO_EVICT;
-                       ttm_bo_move_to_lru_tail(bo, NULL);
+                       ttm_bo_del_from_lru(bo);
+                       ttm_bo_add_mem_to_lru(bo, &bo->mem);
                }
 
                kref_init(&bo->kref);