]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: mvmdio: avoid error message for optional IRQ
authorChris Packham <chris.packham@alliedtelesis.co.nz>
Mon, 16 Mar 2020 07:49:07 +0000 (20:49 +1300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Mar 2020 03:54:37 +0000 (20:54 -0700)
Per the dt-binding the interrupt is optional so use
platform_get_irq_optional() instead of platform_get_irq(). Since
commit 067159824b49 ("driver core: platform: Add an error message to
platform_get_irq*()") platform_get_irq() produces an error message

  orion-mdio f1072004.mdio: IRQ index 0 not found

which is perfectly normal if one hasn't specified the optional property
in the device tree.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvmdio.c

index 0b9e851f3da4fb1a37989e1aed311a5ad282353f..d14762d93640ac4bb69fbd0870423fcf0c696f89 100644 (file)
@@ -347,7 +347,7 @@ static int orion_mdio_probe(struct platform_device *pdev)
        }
 
 
-       dev->err_interrupt = platform_get_irq(pdev, 0);
+       dev->err_interrupt = platform_get_irq_optional(pdev, 0);
        if (dev->err_interrupt > 0 &&
            resource_size(r) < MVMDIO_ERR_INT_MASK + 4) {
                dev_err(&pdev->dev,