]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ASoC: mediatek: mtk-btcvsd: Add checks for write and read of mtk_btcvsd_snd
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Wed, 16 Nov 2022 03:07:50 +0000 (11:07 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:41:06 +0000 (11:41 +0100)
[ Upstream commit d067b3378a78c9c3048ac535e31c171b6f5b5846 ]

As the mtk_btcvsd_snd_write and mtk_btcvsd_snd_read may return error,
it should be better to catch the exception.

Fixes: 0080c6d21193 ("ASoC: mediatek: add btcvsd driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20221116030750.40500-1-jiasheng@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/mediatek/common/mtk-btcvsd.c

index b66f7dee1e149ed1da2f7c9500c44fe88167cf7b..f6ec6937a71bb34ec83f6dc05981522385654b80 100644 (file)
@@ -1054,11 +1054,9 @@ static int mtk_pcm_btcvsd_copy(struct snd_pcm_substream *substream,
        struct mtk_btcvsd_snd *bt = snd_soc_component_get_drvdata(component);
 
        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
-               mtk_btcvsd_snd_write(bt, buf, count);
+               return mtk_btcvsd_snd_write(bt, buf, count);
        else
-               mtk_btcvsd_snd_read(bt, buf, count);
-
-       return 0;
+               return mtk_btcvsd_snd_read(bt, buf, count);
 }
 
 static struct snd_pcm_ops mtk_btcvsd_ops = {