ceph: fix a NULL vs IS_ERR() check when calling ceph_lookup_inode()

The ceph_lookup_inode() function returns error pointers.  It never
returns NULL.

Fixes: aa87052dd965 ("ceph: fix incorrectly showing the .snap size for stat")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
index 4af5e55abc1586748882e54e3da3660d8444aaab..bad9eeb6a1a59db7b507b43b9bd2bd449cf086a0 100644 (file)
--- a/fs/ceph/inode.c
+++ b/fs/ceph/inode.c
@@ -2492,7 +2492,7 @@ int ceph_getattr(struct user_namespace *mnt_userns, const struct path *path,
                        struct inode *parent;
 
                        parent = ceph_lookup_inode(sb, ceph_ino(inode));
-                       if (!parent)
+                       if (IS_ERR(parent))
                                return PTR_ERR(parent);
 
                        pci = ceph_inode(parent);