]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/i915/guc: Only assign guc_id.id when stealing guc_id
authorMatthew Brost <matthew.brost@intel.com>
Tue, 14 Dec 2021 17:04:55 +0000 (09:04 -0800)
committerJani Nikula <jani.nikula@intel.com>
Mon, 20 Dec 2021 11:59:35 +0000 (13:59 +0200)
Previously assigned whole guc_id structure (list, spin lock) which is
incorrect, only assign the guc_id.id.

Fixes: dd0b021b930f8 ("drm/i915/guc: Rework and simplify locking")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211214170500.28569-3-matthew.brost@intel.com
(cherry picked from commit 939d8e9c87e704fd5437e2c8b80929591fe540eb)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c

index c50039a5ba1e6b70beb797f84cee55b5da8cd4a4..302e9ff0602cc11442ee7d55bc6e39108d999e23 100644 (file)
@@ -1662,7 +1662,7 @@ static int steal_guc_id(struct intel_guc *guc, struct intel_context *ce)
                GEM_BUG_ON(intel_context_is_parent(cn));
 
                list_del_init(&cn->guc_id.link);
-               ce->guc_id = cn->guc_id;
+               ce->guc_id.id = cn->guc_id.id;
 
                spin_lock(&cn->guc_state.lock);
                clr_context_registered(cn);