]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ceph: flush release queue when handling caps for unknown inode
authorJeff Layton <jlayton@kernel.org>
Wed, 20 May 2020 14:36:07 +0000 (10:36 -0400)
committerIlya Dryomov <idryomov@gmail.com>
Wed, 27 May 2020 11:03:57 +0000 (13:03 +0200)
It's possible for the VFS to completely forget about an inode, but for
it to still be sitting on the cap release queue. If the MDS sends the
client a cap message for such an inode, it just ignores it today, which
can lead to a stall of up to 5s until the cap release queue is flushed.

If we get a cap message for an inode that can't be located, then go
ahead and flush the cap release queue.

Cc: stable@vger.kernel.org
URL: https://tracker.ceph.com/issues/45532
Fixes: ab2139f50874 ("ceph: delete stale dentry when last reference is dropped")
Reported-and-Tested-by: Andrej Filipčič <andrej.filipcic@ijs.si>
Suggested-by: Yan, Zheng <zyan@redhat.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/caps.c

index 5f3aa4d607def2fd104a8c2349f37555cb53cfc3..f1acde6fb9a6181985e878e981a977719c8c7f68 100644 (file)
@@ -3991,7 +3991,7 @@ void ceph_handle_caps(struct ceph_mds_session *session,
                        __ceph_queue_cap_release(session, cap);
                        spin_unlock(&session->s_cap_lock);
                }
-               goto done;
+               goto flush_cap_releases;
        }
 
        /* these will work even if we don't have a cap yet */