drm/meson: Fix refcount leak in meson_encoder_hdmi_init

commit a4f97b62ea9c062a50cbbfee0fb65bab03e3aada upstream.

of_find_device_by_node() takes reference, we should use put_device()
to release it when not need anymore.
Add missing put_device() in error path to avoid refcount
leak.

Fixes: bcf5446630b8 ("drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220511054052.51981-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/gpu/drm/meson/meson_encoder_hdmi.c b/drivers/gpu/drm/meson/meson_encoder_hdmi.c
index 0d532e8e8ccaa1cc14b529bb250b6111848fd5a4..a7692584487ccd8dd964f88b66794d8b15bcbcde 100644 (file)
--- a/drivers/gpu/drm/meson/meson_encoder_hdmi.c
+++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.c
@@ -438,8 +438,10 @@ int meson_encoder_hdmi_init(struct meson_drm *priv)
                cec_fill_conn_info_from_drm(&conn_info, meson_encoder_hdmi->connector);
 
                notifier = cec_notifier_conn_register(&pdev->dev, NULL, &conn_info);
-               if (!notifier)
+               if (!notifier) {
+                       put_device(&pdev->dev);
                        return -ENOMEM;
+               }
 
                meson_encoder_hdmi->cec_notifier = notifier;
        }