]> git.baikalelectronics.ru Git - kernel.git/commitdiff
genetlink: correct uAPI defines
authorJakub Kicinski <kuba@kernel.org>
Tue, 9 Aug 2022 23:27:40 +0000 (16:27 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 10 Aug 2022 12:49:50 +0000 (13:49 +0100)
Commit 95d4e7fd2965 ("genetlink: properly support per-op policy dumping")
seems to have copy'n'pasted things a little incorrectly.

The #define CTRL_ATTR_MCAST_GRP_MAX should have stayed right
after the previous enum. The new CTRL_ATTR_POLICY_* needs
its own define for MAX and that max should not contain the
superfluous _DUMP in the name.

We probably can't do anything about the CTRL_ATTR_POLICY_DUMP_MAX
any more, there's likely code which uses it. For consistency
(*cough* codegen *cough*) let's add the correctly name define
nonetheless.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/uapi/linux/genetlink.h

index d83f214b4134ab518ecc37318d506df3de987ead..ddba3ca01e39aedd09ee86d1e9145bb66fe09b35 100644 (file)
@@ -87,6 +87,8 @@ enum {
        __CTRL_ATTR_MCAST_GRP_MAX,
 };
 
+#define CTRL_ATTR_MCAST_GRP_MAX (__CTRL_ATTR_MCAST_GRP_MAX - 1)
+
 enum {
        CTRL_ATTR_POLICY_UNSPEC,
        CTRL_ATTR_POLICY_DO,
@@ -96,7 +98,6 @@ enum {
        CTRL_ATTR_POLICY_DUMP_MAX = __CTRL_ATTR_POLICY_DUMP_MAX - 1
 };
 
-#define CTRL_ATTR_MCAST_GRP_MAX (__CTRL_ATTR_MCAST_GRP_MAX - 1)
-
+#define CTRL_ATTR_POLICY_MAX (__CTRL_ATTR_POLICY_DUMP_MAX - 1)
 
 #endif /* _UAPI__LINUX_GENERIC_NETLINK_H */