]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/amd/display: Fix allocate_mst_payload assert on resume
authorRoman Li <Roman.Li@amd.com>
Thu, 17 Mar 2022 23:55:05 +0000 (19:55 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 6 Apr 2022 15:42:32 +0000 (11:42 -0400)
[Why]
On resume we do link detection for all non-MST connectors.
MST is handled separately. However the condition for telling
if connector is on mst branch is not enough for mst hub case.
Link detection for mst branch link leads to mst topology reset.
That causes assert in dc_link_allocate_mst_payload()

[How]
Use link type as indicator for mst link.

Reviewed-by: Wayne Lin <Wayne.Lin@amd.com>
Acked-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Roman Li <Roman.Li@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index b30656959fd862324591d3d3ad73ff465ab642b6..5895afefccb727addb38b2b7f598634cb70da79c 100644 (file)
@@ -2714,7 +2714,8 @@ static int dm_resume(void *handle)
                 * this is the case when traversing through already created
                 * MST connectors, should be skipped
                 */
-               if (aconnector->mst_port)
+               if (aconnector->dc_link &&
+                   aconnector->dc_link->type == dc_connection_mst_branch)
                        continue;
 
                mutex_lock(&aconnector->hpd_lock);