]> git.baikalelectronics.ru Git - kernel.git/commitdiff
octeontx2-af: fix error code in is_valid_offset()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 31 May 2022 07:28:45 +0000 (10:28 +0300)
committerPaolo Abeni <pabeni@redhat.com>
Wed, 1 Jun 2022 09:49:44 +0000 (11:49 +0200)
The is_valid_offset() function returns success/true if the call to
validate_and_get_cpt_blkaddr() fails.

Fixes: ecad2ce8c48f ("octeontx2-af: cn10k: Add mailbox to configure reassembly timeout")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YpXDrTPb8qV01JSP@kili
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c

index a79201a9a6f03e59af9ef00fac3848c77a4caa2b..a9da85e418a494f1a7bcbae306d3e1cd96e064bb 100644 (file)
@@ -579,7 +579,7 @@ static bool is_valid_offset(struct rvu *rvu, struct cpt_rd_wr_reg_msg *req)
 
        blkaddr = validate_and_get_cpt_blkaddr(req->blkaddr);
        if (blkaddr < 0)
-               return blkaddr;
+               return false;
 
        /* Registers that can be accessed from PF/VF */
        if ((offset & 0xFF000) ==  CPT_AF_LFX_CTL(0) ||