]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/i915/tgl: Extend Wa_1606931601 for all steppings
authorAnusha Srivatsa <anusha.srivatsa@intel.com>
Thu, 27 Feb 2020 22:00:54 +0000 (14:00 -0800)
committerJosé Roberto de Souza <jose.souza@intel.com>
Mon, 2 Mar 2020 20:00:41 +0000 (12:00 -0800)
According to BSpec. Wa_1606931601 applies for all TGL steppings.
This patch moves the WA implementation out of A0 only block of
rcs_engine_wa_init().

The WA is has also been referred to by an alternate name
Wa_1607090982.

Bspec: 46045, 52890

Fixes: 3873fd1a43c7 ("drm/i915: Use engine wa list for Wa_1607090982")
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200227220101.321671-4-jose.souza@intel.com
drivers/gpu/drm/i915/gt/intel_workarounds.c

index 927cf2bc9d15b782caa6d9baf30a13dd98c94b25..3021cc127403e79d3b0bc47077616b371b124c85 100644 (file)
@@ -1359,11 +1359,6 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
                            GEN7_FF_THREAD_MODE,
                            GEN12_FF_TESSELATION_DOP_GATE_DISABLE);
 
-               /* Wa_1606931601:tgl */
-               wa_masked_en(wal,
-                            GEN7_ROW_CHICKEN2,
-                            GEN12_DISABLE_EARLY_READ);
-
                /*
                 * Wa_1409085225:tgl
                 * Wa_14010229206:tgl
@@ -1372,6 +1367,9 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
        }
 
        if (IS_TIGERLAKE(i915)) {
+               /* Wa_1606931601:tgl */
+               wa_masked_en(wal, GEN7_ROW_CHICKEN2, GEN12_DISABLE_EARLY_READ);
+
                /* Wa_1409804808:tgl */
                wa_masked_en(wal, GEN7_ROW_CHICKEN2,
                             GEN12_PUSH_CONST_DEREF_HOLD_DIS);