drm/tilcdc: remove check for return value of debugfs functions.

Since 987d65d01356 (drm: debugfs: make
drm_debugfs_create_files() never fail), drm_debugfs_create_files() never
fails. Therefore, remove the check and error handling of the return
value of drm_debugfs_create_files() as it is not needed in
tilcdc_debugfs_init().

Also remove local variables that are not used after the changes.

v2: remove conversion of tilcdc_debugfs_init() to void to avoid build
breakage and enable individual compilation.

References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Acked-by: Jyri Sarha <jsarha@ti.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200310133121.27913-3-wambui.karugax@gmail.com

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 0791a0200cc3c5690d234c612ec6e0fcf6f04d2d..3f7071eb9c78cb67dce72ab5b1292b62dc3e0848 100644 (file)
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -480,24 +480,17 @@ static struct drm_info_list tilcdc_debugfs_list[] = {
 
 static int tilcdc_debugfs_init(struct drm_minor *minor)
 {
-       struct drm_device *dev = minor->dev;
        struct tilcdc_module *mod;
-       int ret;
 
-       ret = drm_debugfs_create_files(tilcdc_debugfs_list,
-                       ARRAY_SIZE(tilcdc_debugfs_list),
-                       minor->debugfs_root, minor);
+       drm_debugfs_create_files(tilcdc_debugfs_list,
+                                ARRAY_SIZE(tilcdc_debugfs_list),
+                                minor->debugfs_root, minor);
 
        list_for_each_entry(mod, &module_list, list)
                if (mod->funcs->debugfs_init)
                        mod->funcs->debugfs_init(mod, minor);
 
-       if (ret) {
-               dev_err(dev->dev, "could not install tilcdc_debugfs_list\n");
-               return ret;
-       }
-
-       return ret;
+       return 0;
 }
 #endif