]> git.baikalelectronics.ru Git - kernel.git/commitdiff
dm writecache: fix unnecessary NULL check warnings
authorTian Tao <tiantao6@hisilicon.com>
Tue, 26 Jan 2021 02:40:02 +0000 (10:40 +0800)
committerMike Snitzer <snitzer@redhat.com>
Wed, 3 Feb 2021 15:10:05 +0000 (10:10 -0500)
Remove NULL checks before vfree() to fix these warnings:
./drivers/md/dm-writecache.c:2008:2-7: WARNING: NULL check before some
freeing functions is not needed.
./drivers/md/dm-writecache.c:2024:2-7: WARNING: NULL check before some
freeing functions is not needed.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-writecache.c

index 1769653c3d6b4fdd2f368e477b916629ccd7c70c..fd531d5a39c290b5d17288903e9a4e6d903f7a0c 100644 (file)
@@ -2004,8 +2004,7 @@ static void writecache_dtr(struct dm_target *ti)
        if (wc->ssd_dev)
                dm_put_device(ti, wc->ssd_dev);
 
-       if (wc->entries)
-               vfree(wc->entries);
+       vfree(wc->entries);
 
        if (wc->memory_map) {
                if (WC_MODE_PMEM(wc))
@@ -2020,8 +2019,7 @@ static void writecache_dtr(struct dm_target *ti)
        if (wc->dm_io)
                dm_io_client_destroy(wc->dm_io);
 
-       if (wc->dirty_bitmap)
-               vfree(wc->dirty_bitmap);
+       vfree(wc->dirty_bitmap);
 
        kfree(wc);
 }