drm/i915: Introduce .set_link_train() vfunc

Sort out some of the mess between intel_ddi.c intel_dp.c by
introducing a .set_link_train() vfunc.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200420200610.31798-1-ville.syrjala@linux.intel.com
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index c086ae5eb12ff84eb1942769cfce80bf345e876a..b8397ea74c802375443cc7c63946d5d82aef45b7 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3950,6 +3950,46 @@ static void intel_ddi_prepare_link_retrain(struct intel_dp *intel_dp)
        udelay(600);
 }
 
+static void intel_ddi_set_link_train(struct intel_dp *intel_dp,
+                                    u8 dp_train_pat)
+{
+       struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
+       u8 train_pat_mask = drm_dp_training_pattern_mask(intel_dp->dpcd);
+       enum port port = dp_to_dig_port(intel_dp)->base.port;
+       u32 temp;
+
+       temp = intel_de_read(dev_priv, intel_dp->regs.dp_tp_ctl);
+
+       if (dp_train_pat & DP_LINK_SCRAMBLING_DISABLE)
+               temp |= DP_TP_CTL_SCRAMBLE_DISABLE;
+       else
+               temp &= ~DP_TP_CTL_SCRAMBLE_DISABLE;
+
+       temp &= ~DP_TP_CTL_LINK_TRAIN_MASK;
+       switch (dp_train_pat & train_pat_mask) {
+       case DP_TRAINING_PATTERN_DISABLE:
+               temp |= DP_TP_CTL_LINK_TRAIN_NORMAL;
+               break;
+       case DP_TRAINING_PATTERN_1:
+               temp |= DP_TP_CTL_LINK_TRAIN_PAT1;
+               break;
+       case DP_TRAINING_PATTERN_2:
+               temp |= DP_TP_CTL_LINK_TRAIN_PAT2;
+               break;
+       case DP_TRAINING_PATTERN_3:
+               temp |= DP_TP_CTL_LINK_TRAIN_PAT3;
+               break;
+       case DP_TRAINING_PATTERN_4:
+               temp |= DP_TP_CTL_LINK_TRAIN_PAT4;
+               break;
+       }
+
+       intel_de_write(dev_priv, intel_dp->regs.dp_tp_ctl, temp);
+
+       intel_de_write(dev_priv, DDI_BUF_CTL(port), intel_dp->DP);
+       intel_de_posting_read(dev_priv, DDI_BUF_CTL(port));
+}
+
 static bool intel_ddi_is_audio_enabled(struct drm_i915_private *dev_priv,
                                       enum transcoder cpu_transcoder)
 {
@@ -4394,6 +4434,8 @@ intel_ddi_init_dp_connector(struct intel_digital_port *intel_dig_port)
        intel_dig_port->dp.output_reg = DDI_BUF_CTL(port);
        intel_dig_port->dp.prepare_link_retrain =
                intel_ddi_prepare_link_retrain;
+       intel_dig_port->dp.set_link_train = intel_ddi_set_link_train;
+
        if (INTEL_GEN(dev_priv) < 12) {
                intel_dig_port->dp.regs.dp_tp_ctl = DP_TP_CTL(port);
                intel_dig_port->dp.regs.dp_tp_status = DP_TP_STATUS(port);

diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index b37129ca0518a092af836356122d6158cbbacd11..991dbd8ed314fb1c2b7e34d3d3de9c7b9c6e0aff 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1367,6 +1367,7 @@ struct intel_dp {
 
        /* This is called before a link training is starterd */
        void (*prepare_link_retrain)(struct intel_dp *intel_dp);
+       void (*set_link_train)(struct intel_dp *intel_dp, u8 dp_train_pat);
 
        /* Displayport compliance testing */
        struct intel_dp_compliance compliance;

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 5c7009b74c247662c7a261562f8224746a3593b3..5e35f98f0fd027d5ccdff0e15b97619491125031 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3618,90 +3618,63 @@ static void chv_post_disable_dp(struct intel_atomic_state *state,
 }
 
 static void
-_intel_dp_set_link_train(struct intel_dp *intel_dp,
-                        u32 *DP,
-                        u8 dp_train_pat)
+cpt_set_link_train(struct intel_dp *intel_dp,
+                  u8 dp_train_pat)
 {
        struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
-       struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
-       enum port port = intel_dig_port->base.port;
-       u8 train_pat_mask = drm_dp_training_pattern_mask(intel_dp->dpcd);
-
-       if (dp_train_pat & train_pat_mask)
-               drm_dbg_kms(&dev_priv->drm,
-                           "Using DP training pattern TPS%d\n",
-                           dp_train_pat & train_pat_mask);
+       u32 *DP = &intel_dp->DP;
 
-       if (HAS_DDI(dev_priv)) {
-               u32 temp = intel_de_read(dev_priv, intel_dp->regs.dp_tp_ctl);
-
-               if (dp_train_pat & DP_LINK_SCRAMBLING_DISABLE)
-                       temp |= DP_TP_CTL_SCRAMBLE_DISABLE;
-               else
-                       temp &= ~DP_TP_CTL_SCRAMBLE_DISABLE;
-
-               temp &= ~DP_TP_CTL_LINK_TRAIN_MASK;
-               switch (dp_train_pat & train_pat_mask) {
-               case DP_TRAINING_PATTERN_DISABLE:
-                       temp |= DP_TP_CTL_LINK_TRAIN_NORMAL;
+       *DP &= ~DP_LINK_TRAIN_MASK_CPT;
 
-                       break;
-               case DP_TRAINING_PATTERN_1:
-                       temp |= DP_TP_CTL_LINK_TRAIN_PAT1;
-                       break;
-               case DP_TRAINING_PATTERN_2:
-                       temp |= DP_TP_CTL_LINK_TRAIN_PAT2;
-                       break;
-               case DP_TRAINING_PATTERN_3:
-                       temp |= DP_TP_CTL_LINK_TRAIN_PAT3;
-                       break;
-               case DP_TRAINING_PATTERN_4:
-                       temp |= DP_TP_CTL_LINK_TRAIN_PAT4;
-                       break;
-               }
-               intel_de_write(dev_priv, intel_dp->regs.dp_tp_ctl, temp);
+       switch (dp_train_pat & DP_TRAINING_PATTERN_MASK) {
+       case DP_TRAINING_PATTERN_DISABLE:
+               *DP |= DP_LINK_TRAIN_OFF_CPT;
+               break;
+       case DP_TRAINING_PATTERN_1:
+               *DP |= DP_LINK_TRAIN_PAT_1_CPT;
+               break;
+       case DP_TRAINING_PATTERN_2:
+               *DP |= DP_LINK_TRAIN_PAT_2_CPT;
+               break;
+       case DP_TRAINING_PATTERN_3:
+               drm_dbg_kms(&dev_priv->drm,
+                           "TPS3 not supported, using TPS2 instead\n");
+               *DP |= DP_LINK_TRAIN_PAT_2_CPT;
+               break;
+       }
 
-       } else if ((IS_IVYBRIDGE(dev_priv) && port == PORT_A) ||
-                  (HAS_PCH_CPT(dev_priv) && port != PORT_A)) {
-               *DP &= ~DP_LINK_TRAIN_MASK_CPT;
+       intel_de_write(dev_priv, intel_dp->output_reg, intel_dp->DP);
+       intel_de_posting_read(dev_priv, intel_dp->output_reg);
+}
 
-               switch (dp_train_pat & DP_TRAINING_PATTERN_MASK) {
-               case DP_TRAINING_PATTERN_DISABLE:
-                       *DP |= DP_LINK_TRAIN_OFF_CPT;
-                       break;
-               case DP_TRAINING_PATTERN_1:
-                       *DP |= DP_LINK_TRAIN_PAT_1_CPT;
-                       break;
-               case DP_TRAINING_PATTERN_2:
-                       *DP |= DP_LINK_TRAIN_PAT_2_CPT;
-                       break;
-               case DP_TRAINING_PATTERN_3:
-                       drm_dbg_kms(&dev_priv->drm,
-                                   "TPS3 not supported, using TPS2 instead\n");
-                       *DP |= DP_LINK_TRAIN_PAT_2_CPT;
-                       break;
-               }
+static void
+g4x_set_link_train(struct intel_dp *intel_dp,
+                  u8 dp_train_pat)
+{
+       struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
+       u32 *DP = &intel_dp->DP;
 
-       } else {
-               *DP &= ~DP_LINK_TRAIN_MASK;
+       *DP &= ~DP_LINK_TRAIN_MASK;
 
-               switch (dp_train_pat & DP_TRAINING_PATTERN_MASK) {
-               case DP_TRAINING_PATTERN_DISABLE:
-                       *DP |= DP_LINK_TRAIN_OFF;
-                       break;
-               case DP_TRAINING_PATTERN_1:
-                       *DP |= DP_LINK_TRAIN_PAT_1;
-                       break;
-               case DP_TRAINING_PATTERN_2:
-                       *DP |= DP_LINK_TRAIN_PAT_2;
-                       break;
-               case DP_TRAINING_PATTERN_3:
-                       drm_dbg_kms(&dev_priv->drm,
-                                   "TPS3 not supported, using TPS2 instead\n");
-                       *DP |= DP_LINK_TRAIN_PAT_2;
-                       break;
-               }
+       switch (dp_train_pat & DP_TRAINING_PATTERN_MASK) {
+       case DP_TRAINING_PATTERN_DISABLE:
+               *DP |= DP_LINK_TRAIN_OFF;
+               break;
+       case DP_TRAINING_PATTERN_1:
+               *DP |= DP_LINK_TRAIN_PAT_1;
+               break;
+       case DP_TRAINING_PATTERN_2:
+               *DP |= DP_LINK_TRAIN_PAT_2;
+               break;
+       case DP_TRAINING_PATTERN_3:
+               drm_dbg_kms(&dev_priv->drm,
+                           "TPS3 not supported, using TPS2 instead\n");
+               *DP |= DP_LINK_TRAIN_PAT_2;
+               break;
        }
+
+       intel_de_write(dev_priv, intel_dp->output_reg, intel_dp->DP);
+       intel_de_posting_read(dev_priv, intel_dp->output_reg);
 }
 
 static void intel_dp_enable_port(struct intel_dp *intel_dp,
@@ -4358,14 +4331,15 @@ void
 intel_dp_program_link_training_pattern(struct intel_dp *intel_dp,
                                       u8 dp_train_pat)
 {
-       struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
-       struct drm_i915_private *dev_priv =
-               to_i915(intel_dig_port->base.base.dev);
+       struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
+       u8 train_pat_mask = drm_dp_training_pattern_mask(intel_dp->dpcd);
 
-       _intel_dp_set_link_train(intel_dp, &intel_dp->DP, dp_train_pat);
+       if (dp_train_pat & train_pat_mask)
+               drm_dbg_kms(&dev_priv->drm,
+                           "Using DP training pattern TPS%d\n",
+                           dp_train_pat & train_pat_mask);
 
-       intel_de_write(dev_priv, intel_dp->output_reg, intel_dp->DP);
-       intel_de_posting_read(dev_priv, intel_dp->output_reg);
+       intel_dp->set_link_train(intel_dp, dp_train_pat);
 }
 
 void intel_dp_set_idle_link_train(struct intel_dp *intel_dp)
@@ -8515,6 +8489,12 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
                intel_encoder->post_disable = g4x_post_disable_dp;
        }
 
+       if ((IS_IVYBRIDGE(dev_priv) && port == PORT_A) ||
+           (HAS_PCH_CPT(dev_priv) && port != PORT_A))
+               intel_dig_port->dp.set_link_train = cpt_set_link_train;
+       else
+               intel_dig_port->dp.set_link_train = g4x_set_link_train;
+
        intel_dig_port->dp.output_reg = output_reg;
        intel_dig_port->max_lanes = 4;
        intel_dig_port->dp.regs.dp_tp_ctl = DP_TP_CTL(port);