]> git.baikalelectronics.ru Git - kernel.git/commitdiff
dm bufio: fix error code in dm_bufio_write_dirty_buffers()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 12 Jul 2017 07:26:34 +0000 (10:26 +0300)
committerMike Snitzer <snitzer@redhat.com>
Tue, 25 Jul 2017 14:11:15 +0000 (10:11 -0400)
We should be returning normal negative error codes here.  The "a"
variables comes from &c->async_write_error which is a blk_status_t
converted to a regular error code.

In the current code, the blk_status_t gets propogated back to
pool_create() and eventually results in an Oops.

Fixes: 4e4cbee93d56 ("block: switch bios to blk_status_t")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-bufio.c

index 850ff6c6799449541cf8c0357cf7efa17d9e8c60..44f4a8ac95bd5a3a0f7742291c4827a27e27b3b5 100644 (file)
@@ -1258,8 +1258,7 @@ EXPORT_SYMBOL_GPL(dm_bufio_write_dirty_buffers_async);
  */
 int dm_bufio_write_dirty_buffers(struct dm_bufio_client *c)
 {
-       blk_status_t a;
-       int f;
+       int a, f;
        unsigned long buffers_processed = 0;
        struct dm_buffer *b, *tmp;