]> git.baikalelectronics.ru Git - kernel.git/commitdiff
platform/x86: panasonic-laptop: Resolve hotkey double trigger bug
authorKenneth Chan <kenneth.t.chan@gmail.com>
Fri, 21 Aug 2020 18:14:31 +0000 (02:14 +0800)
committerHans de Goede <hdegoede@redhat.com>
Tue, 10 Nov 2020 13:49:50 +0000 (14:49 +0100)
Sometimes double ACPI events are triggered for brightness, vol and mute
hotkeys. This patch fixes it.

Signed-off-by: Kenneth Chan <kenneth.t.chan@gmail.com>
Link: https://lore.kernel.org/r/20200821181433.17653-8-kenneth.t.chan@gmail.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/panasonic-laptop.c

index 3b0294ee9d3e48b1f41bc8fa000d905d8cf3cb4c..6779099a3ec99e604b408c4aa9a11e5dd2cca825 100644 (file)
@@ -13,6 +13,7 @@
  *
  * ChangeLog:
  *     Aug.18, 2020    Kenneth Chan <kenneth.t.chan@gmail.com>
+ *                     resolve hotkey double trigger
  *                     add write support to mute
  *                     fix sticky_key init bug
  *                     fix naming of platform files for consistency with other
@@ -597,9 +598,11 @@ static void acpi_pcc_generate_keyinput(struct pcc_acpi *pcc)
                                        result & 0xf, 0x80, false);
        }
 
-       if (!sparse_keymap_report_event(hotk_input_dev,
-                                       result & 0xf, result & 0x80, false))
-               pr_err("Unknown hotkey event: 0x%04llx\n", result);
+       if ((result & 0xf) == 0x7 || (result & 0xf) == 0x9 || (result & 0xf) == 0xa) {
+               if (!sparse_keymap_report_event(hotk_input_dev,
+                                               result & 0xf, result & 0x80, false))
+                       pr_err("Unknown hotkey event: 0x%04llx\n", result);
+       }
 }
 
 static void acpi_pcc_hotkey_notify(struct acpi_device *device, u32 event)