]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: phy: ax88772a: fix lost pause advertisement configuration
authorOleksij Rempel <o.rempel@pengutronix.de>
Tue, 28 Jun 2022 11:43:49 +0000 (13:43 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 30 Jun 2022 03:39:05 +0000 (20:39 -0700)
In case of asix_ax88772a_link_change_notify() workaround, we run soft
reset which will automatically clear MII_ADVERTISE configuration. The
PHYlib framework do not know about changed configuration state of the
PHY, so we need use phy_init_hw() to reinit PHY configuration.

Fixes: 877cfd219ba7 ("net: usb/phy: asix: add support for ax88772A/C PHYs")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220628114349.3929928-1-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/ax88796b.c

index 4578963375055391b503011787672bbff41e11c8..0f1e617a26c9154b2fda61956fe4689ad3ede911 100644 (file)
@@ -88,8 +88,10 @@ static void asix_ax88772a_link_change_notify(struct phy_device *phydev)
        /* Reset PHY, otherwise MII_LPA will provide outdated information.
         * This issue is reproducible only with some link partner PHYs
         */
-       if (phydev->state == PHY_NOLINK && phydev->drv->soft_reset)
-               phydev->drv->soft_reset(phydev);
+       if (phydev->state == PHY_NOLINK) {
+               phy_init_hw(phydev);
+               phy_start_aneg(phydev);
+       }
 }
 
 static struct phy_driver asix_driver[] = {