]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: usb: asix: ax88772: fix boolconv.cocci warnings
authorkernel test robot <lkp@intel.com>
Wed, 25 Aug 2021 18:35:38 +0000 (20:35 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 25 Aug 2021 23:35:51 +0000 (16:35 -0700)
drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

Fixes: 7a141e64cf14 ("net: usb: asix: ax88772: move embedded PHY detection as early as possible")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/r/20210825183538.13070-1-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/asix_devices.c

index f6f3955a3a0f0ebbd9a8a31568a314b41c54274d..dc87e8caf954af6b86a776e56941c3055637492e 100644 (file)
@@ -754,7 +754,7 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf)
                return ret;
 
        priv->phy_addr = ret;
-       priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10 ? true : false);
+       priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10);
 
        asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, &chipcode, 0);
        chipcode &= AX_CHIPCODE_MASK;