]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ipmi: kcs: Fix aspeed_kcs_probe_of_v1()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 7 Apr 2020 12:21:49 +0000 (15:21 +0300)
committerCorey Minyard <cminyard@mvista.com>
Tue, 7 Apr 2020 13:35:40 +0000 (08:35 -0500)
This needs to return the newly allocated struct but instead it returns
zero which leads to an immediate Oops in the caller.

Fixes: 09f5f680707e ("ipmi: kcs: aspeed: Implement v2 bindings")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Message-Id: <20200407122149.GA100026@mwanda>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/kcs_bmc_aspeed.c

index 9422d55a0476a2cc710a35dc8ab4e060a627b8f7..a140203c079bad7cbd52358985daf4963b7eabc1 100644 (file)
@@ -271,7 +271,7 @@ static struct kcs_bmc *aspeed_kcs_probe_of_v1(struct platform_device *pdev)
        kcs->ioreg = ast_kcs_bmc_ioregs[channel - 1];
        aspeed_kcs_set_address(kcs, slave);
 
-       return 0;
+       return kcs;
 }
 
 static int aspeed_kcs_calculate_channel(const struct kcs_ioreg *regs)