]> git.baikalelectronics.ru Git - kernel.git/commitdiff
hinic: fix wrong para of wait_for_completion_timeout
authorLuo bin <luobin9@huawei.com>
Fri, 20 Mar 2020 23:13:19 +0000 (23:13 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 22 Mar 2020 02:43:38 +0000 (19:43 -0700)
the second input parameter of wait_for_completion_timeout should
be jiffies instead of millisecond

Signed-off-by: Luo bin <luobin9@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c
drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c

index 33f93cc25193a6008d696c96b8854d5bc1e49f32..5f2d57d1b2d37a42c1f8a2d5454484352c8183d3 100644 (file)
@@ -389,7 +389,8 @@ static int cmdq_sync_cmd_direct_resp(struct hinic_cmdq *cmdq,
 
        spin_unlock_bh(&cmdq->cmdq_lock);
 
-       if (!wait_for_completion_timeout(&done, CMDQ_TIMEOUT)) {
+       if (!wait_for_completion_timeout(&done,
+                                        msecs_to_jiffies(CMDQ_TIMEOUT))) {
                spin_lock_bh(&cmdq->cmdq_lock);
 
                if (cmdq->errcode[curr_prod_idx] == &errcode)
index c1a6be6bf6a8ce1cc8c742ece43e890429906509..8995e32dd1c001450988bcb7ca349b103ef0f39f 100644 (file)
@@ -43,7 +43,7 @@
 
 #define MSG_NOT_RESP                    0xFFFF
 
-#define MGMT_MSG_TIMEOUT                1000
+#define MGMT_MSG_TIMEOUT                5000
 
 #define mgmt_to_pfhwdev(pf_mgmt)        \
                container_of(pf_mgmt, struct hinic_pfhwdev, pf_to_mgmt)
@@ -267,7 +267,8 @@ static int msg_to_mgmt_sync(struct hinic_pf_to_mgmt *pf_to_mgmt,
                goto unlock_sync_msg;
        }
 
-       if (!wait_for_completion_timeout(recv_done, MGMT_MSG_TIMEOUT)) {
+       if (!wait_for_completion_timeout(recv_done,
+                                        msecs_to_jiffies(MGMT_MSG_TIMEOUT))) {
                dev_err(&pdev->dev, "MGMT timeout, MSG id = %d\n", msg_id);
                err = -ETIMEDOUT;
                goto unlock_sync_msg;