]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ASoC: soc-core: skip zero num_dai component in searching dai name
authorShengjiu Wang <shengjiu.wang@nxp.com>
Thu, 10 Feb 2022 11:19:12 +0000 (19:19 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 15 Feb 2022 12:52:45 +0000 (12:52 +0000)
In the case like dmaengine which's not a dai but as a component, the
num_dai is zero, dmaengine component has the same component_of_node
as cpu dai, when cpu dai component is not ready, but dmaengine component
is ready, try to get cpu dai name, the snd_soc_get_dai_name() return
-EINVAL, not -EPROBE_DEFER, that cause below error:

asoc-simple-card <card name>: parse error -22
asoc-simple-card: probe of <card name> failed with error -22

The sound card failed to probe.

So this patch fixes the issue above by skipping the zero num_dai
component in searching dai name.

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Link: https://lore.kernel.org/r/1644491952-7457-1-git-send-email-shengjiu.wang@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-core.c

index 434e61b46983cf647009efba9ab7cfe1d406995a..a088bc9f7dd7c33444f203d231d64f30d0f50725 100644 (file)
@@ -3233,7 +3233,7 @@ int snd_soc_get_dai_name(const struct of_phandle_args *args,
        for_each_component(pos) {
                struct device_node *component_of_node = soc_component_to_node(pos);
 
-               if (component_of_node != args->np)
+               if (component_of_node != args->np || !pos->num_dai)
                        continue;
 
                ret = snd_soc_component_of_xlate_dai_name(pos, args, dai_name);