]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ASoC: acp: check the return value of devm_kzalloc() in acp_legacy_dai_links_create()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 25 Feb 2022 13:16:45 +0000 (05:16 -0800)
committerMark Brown <broonie@kernel.org>
Fri, 25 Feb 2022 13:45:41 +0000 (13:45 +0000)
The function devm_kzalloc() in acp_legacy_dai_links_create() can fail,
so its return value should be checked.

Fixes: fc0ab779fcd4 ("ASoC: amd: acp: Add generic machine driver support for ACP cards")
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Link: https://lore.kernel.org/r/20220225131645.27556-1-baijiaju1990@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp/acp-mach-common.c

index d3034ee2ff59d6cdb18cb6b220951f53fd5a93db..755215d947cf09fffcf49457926250973df0d44a 100644 (file)
@@ -584,6 +584,8 @@ int acp_legacy_dai_links_create(struct snd_soc_card *card)
                num_links++;
 
        links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) * num_links, GFP_KERNEL);
+       if (!links)
+               return -ENOMEM;
 
        if (drv_data->hs_cpu_id == I2S_SP) {
                links[i].name = "acp-headset-codec";