sh_eth: sh_eth_close() always returns 0

sh_eth_close() always returns 0, hence the check in sh_eth_wol_restore()
is pointless (however we cannot change the prototype of sh_eth_close() as
it implements the driver's ndo_stop() method).

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 8aa91e99227dd55cfac63541d02555dd2d89432e..9ff6089905d6813165fbe9530a43c5227f6c4efb 100644 (file)
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -3444,9 +3444,7 @@ static int sh_eth_wol_restore(struct net_device *ndev)
         * both be reset and all registers restored. This is what
         * happens during suspend and resume without WoL enabled.
         */
-       ret = sh_eth_close(ndev);
-       if (ret < 0)
-               return ret;
+       sh_eth_close(ndev);
        ret = sh_eth_open(ndev);
        if (ret < 0)
                return ret;