]> git.baikalelectronics.ru Git - kernel.git/commitdiff
gianfar: ethtool: Fix refcount leak in gfar_get_ts_info
authorMiaoqian Lin <linmq006@gmail.com>
Thu, 10 Mar 2022 01:53:13 +0000 (01:53 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 10 Mar 2022 20:20:54 +0000 (12:20 -0800)
The of_find_compatible_node() function returns a node pointer with
refcount incremented, We should use of_node_put() on it when done
Add the missing of_node_put() to release the refcount.

Fixes: e8c33fba7e22 ("net: ethernet: gianfar_ethtool: get phc index through drvdata")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Link: https://lore.kernel.org/r/20220310015313.14938-1-linmq006@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/gianfar_ethtool.c

index ff756265d58faf2e2d5af0e05e7a41d927ee8745..9a2c16d69e2c1ae7657811cd6060d4187ee719b7 100644 (file)
@@ -1464,6 +1464,7 @@ static int gfar_get_ts_info(struct net_device *dev,
        ptp_node = of_find_compatible_node(NULL, NULL, "fsl,etsec-ptp");
        if (ptp_node) {
                ptp_dev = of_find_device_by_node(ptp_node);
+               of_node_put(ptp_node);
                if (ptp_dev)
                        ptp = platform_get_drvdata(ptp_dev);
        }