]> git.baikalelectronics.ru Git - kernel.git/commitdiff
tracing/histogram: Fix a potential memory leak for kstrdup()
authorXiaoke Wang <xkernel.wang@foxmail.com>
Tue, 25 Jan 2022 04:07:15 +0000 (12:07 +0800)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Fri, 28 Jan 2022 00:15:44 +0000 (19:15 -0500)
kfree() is missing on an error path to free the memory allocated by
kstrdup():

  p = param = kstrdup(data->params[i], GFP_KERNEL);

So it is better to free it via kfree(p).

Link: https://lkml.kernel.org/r/tencent_C52895FD37802832A3E5B272D05008866F0A@qq.com
Cc: stable@vger.kernel.org
Fixes: d380dcde9a07c ("tracing: Fix now invalid var_ref_vals assumption in trace action")
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events_hist.c

index 5e6a988a8a517e44ad86cfefd14d8bf436e49a26..cd9610688ddcac2e4b50b28f74e1b38c54ca5a44 100644 (file)
@@ -3935,6 +3935,7 @@ static int trace_action_create(struct hist_trigger_data *hist_data,
 
                        var_ref_idx = find_var_ref_idx(hist_data, var_ref);
                        if (WARN_ON(var_ref_idx < 0)) {
+                               kfree(p);
                                ret = var_ref_idx;
                                goto err;
                        }