]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/etnaviv: exec and MMU state is lost when resetting the GPU
authorLucas Stach <l.stach@pengutronix.de>
Fri, 20 Aug 2021 20:18:27 +0000 (22:18 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 10:26:40 +0000 (12:26 +0200)
commit 725cbc7884c37f3b4f1777bc1aea6432cded8ca5 upstream.

When the GPU is reset both the current exec state, as well as all MMU
state is lost. Move the driver side state tracking into the reset function
to keep hardware and software state from diverging.

Cc: stable@vger.kernel.org # 5.4
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Tested-by: Michael Walle <michael@walle.cc>
Tested-by: Marek Vasut <marex@denx.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/etnaviv/etnaviv_gpu.c

index efec0bbf85230b13de74d2b4b29fcb1ce5341f57..70d80b2016b6e77fe1db21b0da13cd6b0bdc1cf1 100644 (file)
@@ -546,6 +546,8 @@ static int etnaviv_hw_reset(struct etnaviv_gpu *gpu)
        etnaviv_gpu_update_clock(gpu);
 
        gpu->fe_running = false;
+       gpu->exec_state = -1;
+       gpu->mmu_context = NULL;
 
        return 0;
 }
@@ -794,7 +796,6 @@ int etnaviv_gpu_init(struct etnaviv_gpu *gpu)
        /* Now program the hardware */
        mutex_lock(&gpu->lock);
        etnaviv_gpu_hw_init(gpu);
-       gpu->exec_state = -1;
        mutex_unlock(&gpu->lock);
 
        pm_runtime_mark_last_busy(gpu->dev);
@@ -998,8 +999,6 @@ void etnaviv_gpu_recover_hang(struct etnaviv_gpu *gpu)
        spin_unlock(&gpu->event_spinlock);
 
        etnaviv_gpu_hw_init(gpu);
-       gpu->exec_state = -1;
-       gpu->mmu_context = NULL;
 
        mutex_unlock(&gpu->lock);
        pm_runtime_mark_last_busy(gpu->dev);