]> git.baikalelectronics.ru Git - kernel.git/commitdiff
gpio: dwapb: Don't print error on -EPROBE_DEFER
authorBaikal Electronics <support@baikalelectronics.ru>
Fri, 10 Jun 2022 10:45:00 +0000 (13:45 +0300)
committerBartosz Golaszewski <brgl@bgdev.pl>
Fri, 10 Jun 2022 12:26:15 +0000 (14:26 +0200)
Currently if the APB or Debounce clocks aren't yet ready to be requested
the DW GPIO driver will correctly handle that by deferring the probe
procedure, but the error is still printed to the system log. It needlessly
pollutes the log since there was no real error but a request to postpone
the clock request procedure since the clocks subsystem hasn't been fully
initialized yet. Let's fix that by using the dev_err_probe method to print
the APB/clock request error status. It will correctly handle the deferred
probe situation and print the error if it actually happens.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpio-dwapb.c

index 04afe728e18748df88e11518b739a394a56a8bc5..c22fcaa44a614c66ee5ae0105abb71148bf09650 100644 (file)
@@ -662,10 +662,9 @@ static int dwapb_get_clks(struct dwapb_gpio *gpio)
        gpio->clks[1].id = "db";
        err = devm_clk_bulk_get_optional(gpio->dev, DWAPB_NR_CLOCKS,
                                         gpio->clks);
-       if (err) {
-               dev_err(gpio->dev, "Cannot get APB/Debounce clocks\n");
-               return err;
-       }
+       if (err)
+               return dev_err_probe(gpio->dev, err,
+                                    "Cannot get APB/Debounce clocks\n");
 
        err = clk_bulk_prepare_enable(DWAPB_NR_CLOCKS, gpio->clks);
        if (err) {