scsi: qedf: Remove an unneeded NULL check on list iterator

The list iterator 'fcport' is always non-NULL so it doesn't need to be
checked. Thus just remove the unnecessary NULL check. Also remove the
unnecessary initializer because the list iterator is always initialized.
And adjust the position of blank lines.

Link: https://lore.kernel.org/r/20220405004055.24312-1-xiam0nd.tong@gmail.com
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 18dc68d577b6e231b81ee5ea2523133abc10ec24..cbe01915da8c1579b9013d3d90fc98c6a3bda278 100644 (file)
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -873,7 +873,7 @@ static int qedf_eh_device_reset(struct scsi_cmnd *sc_cmd)
 
 bool qedf_wait_for_upload(struct qedf_ctx *qedf)
 {
-       struct qedf_rport *fcport = NULL;
+       struct qedf_rport *fcport;
        int wait_cnt = 120;
 
        while (wait_cnt--) {
@@ -888,7 +888,7 @@ bool qedf_wait_for_upload(struct qedf_ctx *qedf)
 
        rcu_read_lock();
        list_for_each_entry_rcu(fcport, &qedf->fcports, peers) {
-               if (fcport && test_bit(QEDF_RPORT_SESSION_READY,
+               if (test_bit(QEDF_RPORT_SESSION_READY,
                                       &fcport->flags)) {
                        if (fcport->rdata)
                                QEDF_ERR(&qedf->dbg_ctx,
@@ -899,9 +899,9 @@ bool qedf_wait_for_upload(struct qedf_ctx *qedf)
                                         "Waiting for fcport %p.\n", fcport);
                        }
        }
+
        rcu_read_unlock();
        return false;
-
 }
 
 /* Performs soft reset of qedf_ctx by simulating a link down/up */