]> git.baikalelectronics.ru Git - kernel.git/commitdiff
btrfs: zoned: remove redundant initialization of to_add
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fri, 21 Jan 2022 11:43:51 +0000 (19:43 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 14 Mar 2022 12:13:47 +0000 (13:13 +0100)
to_add is being initialized to len but this is never read as to_add is
overwritten later on. Remove the redundant initialization.

Cleans up the following clang-analyzer warning:

fs/btrfs/extent-tree.c:2769:8: warning: Value stored to 'to_add' during
its initialization is never read [clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent-tree.c

index 96427b1ecac3eacc11c81683cf8e6daa50b4d2d1..b7b49b4eb68dbd7106d71379040766d22f909cfd 100644 (file)
@@ -2766,12 +2766,11 @@ static int unpin_extent_range(struct btrfs_fs_info *fs_info,
                spin_unlock(&cache->lock);
                if (!readonly && return_free_space &&
                    global_rsv->space_info == space_info) {
-                       u64 to_add = len;
-
                        spin_lock(&global_rsv->lock);
                        if (!global_rsv->full) {
-                               to_add = min(len, global_rsv->size -
-                                            global_rsv->reserved);
+                               u64 to_add = min(len, global_rsv->size -
+                                                     global_rsv->reserved);
+
                                global_rsv->reserved += to_add;
                                btrfs_space_info_update_bytes_may_use(fs_info,
                                                space_info, to_add);