]> git.baikalelectronics.ru Git - kernel.git/commitdiff
io_uring/rw: fix error'ed retry return values
authorPavel Begunkov <asml.silence@gmail.com>
Tue, 13 Sep 2022 12:21:23 +0000 (13:21 +0100)
committerJens Axboe <axboe@kernel.dk>
Tue, 13 Sep 2022 13:47:11 +0000 (07:47 -0600)
Kernel test robot reports that we test negativity of an unsigned in
io_fixup_rw_res() after a recent change, which masks error codes and
messes up the return value in case I/O is re-retried and failed with
an error.

Fixes: a0962b6aa95ab ("io_uring/rw: fix short rw error handling")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/9754a0970af1861e7865f9014f735c70dc60bf79.1663071587.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/rw.c

index 1e18a44adcf5b08c41f9e5adba50f1d3058e9601..76ebcfebc9a6e32f93b78f42fab0da9ae38c9893 100644 (file)
@@ -206,7 +206,7 @@ static bool __io_complete_rw_common(struct io_kiocb *req, long res)
        return false;
 }
 
-static inline unsigned io_fixup_rw_res(struct io_kiocb *req, unsigned res)
+static inline int io_fixup_rw_res(struct io_kiocb *req, long res)
 {
        struct io_async_rw *io = req->async_data;