]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net/dsa/hirschmann: Add missing of_node_get() in hellcreek_led_setup()
authorLiang He <windhl@126.com>
Wed, 22 Jun 2022 04:06:21 +0000 (12:06 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 24 Jun 2022 03:39:22 +0000 (20:39 -0700)
of_find_node_by_name() will decrease the refcount of its first arg and
we need a of_node_get() to keep refcount balance.

Fixes: ae00d6af7864 ("net: dsa: hellcreek: Add PTP status LEDs")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220622040621.4094304-1-windhl@126.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/hirschmann/hellcreek_ptp.c

index 2572c6087bb5a192756248410a380ffd8a391388..b28baab6d56a17bcc1bb44846aefcbcdff4a08d4 100644 (file)
@@ -300,6 +300,7 @@ static int hellcreek_led_setup(struct hellcreek *hellcreek)
        const char *label, *state;
        int ret = -EINVAL;
 
+       of_node_get(hellcreek->dev->of_node);
        leds = of_find_node_by_name(hellcreek->dev->of_node, "leds");
        if (!leds) {
                dev_err(hellcreek->dev, "No LEDs specified in device tree!\n");