crypto: brcm - Avoid double free in ahash_finup()

In Broadcom SPU driver, in case where incremental hash
is done in software in ahash_finup(), tmpbuf was freed
twice.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rob Rice <rob.rice@broadcom.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c
index a654a01ff2ba29f5e2dc5f5d1d002902e53cfee2..cc0d5b98006ea9e8f66faf08cdb33f63fd77092a 100644 (file)
--- a/drivers/crypto/bcm/cipher.c
+++ b/drivers/crypto/bcm/cipher.c
@@ -2331,7 +2331,6 @@ static int ahash_finup(struct ahash_request *req)
                /* Call synchronous update */
                ret = crypto_shash_finup(ctx->shash, tmpbuf, req->nbytes,
                                         req->result);
-               kfree(tmpbuf);
        } else {
                /* Otherwise call the internal function which uses SPU hw */
                return __ahash_finup(req);