]> git.baikalelectronics.ru Git - kernel.git/commitdiff
modpost: restore the warning message for missing symbol versions
authorMasahiro Yamada <masahiroy@kernel.org>
Fri, 1 Apr 2022 15:56:10 +0000 (00:56 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Sat, 2 Apr 2022 18:11:51 +0000 (03:11 +0900)
This log message was accidentally chopped off.

I was wondering why this happened, but checking the ML log, Mark
precisely followed my suggestion [1].

I just used "..." because I was too lazy to type the sentence fully.
Sorry for the confusion.

[1]: https://lore.kernel.org/all/CAK7LNAR6bXXk9-ZzZYpTqzFqdYbQsZHmiWspu27rtsFxvfRuVA@mail.gmail.com/

Fixes: 6f2ae4b2b13f ("kbuild: modpost: Explicitly warn about unprototyped symbols")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
scripts/mod/modpost.c

index d10f93aac1c8215169c3c3c86aef6f1039b52a28..ed9d056d2108a2c4123f63f812fff1c0686392ba 100644 (file)
@@ -674,7 +674,7 @@ static void handle_modversion(const struct module *mod,
        unsigned int crc;
 
        if (sym->st_shndx == SHN_UNDEF) {
-               warn("EXPORT symbol \"%s\" [%s%s] version ...\n"
+               warn("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n"
                     "Is \"%s\" prototyped in <asm/asm-prototypes.h>?\n",
                     symname, mod->name, mod->is_vmlinux ? "" : ".ko",
                     symname);