]> git.baikalelectronics.ru Git - kernel.git/commitdiff
sctp: use init_tag from inithdr for ABORT chunk
authorXin Long <lucien.xin@gmail.com>
Wed, 20 Oct 2021 11:42:41 +0000 (07:42 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Nov 2021 18:46:14 +0000 (19:46 +0100)
[ Upstream commit 4f7019c7eb33967eb87766e0e4602b5576873680 ]

Currently Linux SCTP uses the verification tag of the existing SCTP
asoc when failing to process and sending the packet with the ABORT
chunk. This will result in the peer accepting the ABORT chunk and
removing the SCTP asoc. One could exploit this to terminate a SCTP
asoc.

This patch is to fix it by always using the initiate tag of the
received INIT chunk for the ABORT chunk to be sent.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sctp/sm_statefuns.c

index 82a202d71a31ebb48ac39799d5d78ef2cdad857d..962b848459f5d38a86cd2dcead24e91a54be5797 100644 (file)
@@ -6248,6 +6248,7 @@ static struct sctp_packet *sctp_ootb_pkt_new(
                 * yet.
                 */
                switch (chunk->chunk_hdr->type) {
+               case SCTP_CID_INIT:
                case SCTP_CID_INIT_ACK:
                {
                        struct sctp_initack_chunk *initack;