]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: wwan: iosm: fix memory leak in ipc_wwan_dellink
authorHW He <hw.he@mediatek.com>
Thu, 3 Nov 2022 10:40:00 +0000 (18:40 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Nov 2022 09:36:56 +0000 (09:36 +0000)
IOSM driver registers network device without setting the
needs_free_netdev flag, and does NOT call free_netdev() when
unregisters network device, which causes a memory leak.

This patch sets needs_free_netdev to true when registers
network device, which makes netdev subsystem call free_netdev()
automatically after unregister_netdevice().

Fixes: 2b9c90d1efaa ("net: iosm: net driver")
Signed-off-by: HW He <hw.he@mediatek.com>
Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
Signed-off-by: Zhaoping Shu <zhaoping.shu@mediatek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wwan/iosm/iosm_ipc_wwan.c

index 2f1f8b5d5b59532baa30b148a760635e89c2dc68..0108d8d01ff2640dc92e65332aa4de124adeae6a 100644 (file)
@@ -168,6 +168,7 @@ static void ipc_wwan_setup(struct net_device *iosm_dev)
        iosm_dev->max_mtu = ETH_MAX_MTU;
 
        iosm_dev->flags = IFF_POINTOPOINT | IFF_NOARP;
+       iosm_dev->needs_free_netdev = true;
 
        iosm_dev->netdev_ops = &ipc_inm_ops;
 }