block: make bioset_exit() fully resilient against being called twice

Most of bioset_exit() is fine being called twice, as it clears the
various allocations etc when they are freed. The exception is
bio_alloc_cache_destroy(), which does not clear ->cache when it has
freed it.

This isn't necessarily a bug, but can be if buggy users does call the
exit path more then once, or with just a memset() bioset which has
never been initialized. dm appears to be one such user.

Fixes: eeb01ae66618 ("bio: add allocation cache abstraction")
Link: https://lore.kernel.org/linux-block/YpK7m+14A+pZKs5k@casper.infradead.org/
Reported-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/block/bio.c b/block/bio.c
index 8a1b3d650a7f73e6aa857f781a6aba50a1046d9d..f92d0223247b7ad851f82ad32b0fa4abe18b5209 100644 (file)
--- a/block/bio.c
+++ b/block/bio.c
@@ -722,6 +722,7 @@ static void bio_alloc_cache_destroy(struct bio_set *bs)
                bio_alloc_cache_prune(cache, -1U);
        }
        free_percpu(bs->cache);
+       bs->cache = NULL;
 }
 
 /**