]> git.baikalelectronics.ru Git - kernel.git/commitdiff
media: ov7670: remove ov7670_power_off from ov7670_remove
authorDongliang Mu <mudongliangabcd@gmail.com>
Fri, 22 Apr 2022 08:54:05 +0000 (10:54 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Tue, 17 May 2022 07:09:29 +0000 (09:09 +0200)
In ov7670_probe, it always invokes ov7670_power_off() no matter
the execution is successful or failed. So we cannot invoke it
agiain in ov7670_remove().

Fix this by removing ov7670_power_off from ov7670_remove.

Fixes: 4b14b7073ba0 ("media: ov7670: control clock along with power")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/ov7670.c

index 196746423116021c8cc5842661c5417bda5c5ff6..1be2c0e5bdc1580d5a4d2e6a48e37f85bfa77c51 100644 (file)
@@ -2017,7 +2017,6 @@ static int ov7670_remove(struct i2c_client *client)
        v4l2_async_unregister_subdev(sd);
        v4l2_ctrl_handler_free(&info->hdl);
        media_entity_cleanup(&info->sd.entity);
-       ov7670_power_off(sd);
        return 0;
 }